flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] pnowojski commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode
Date Fri, 15 Mar 2019 13:56:37 GMT
pnowojski commented on a change in pull request #7713: [FLINK-10995][network] Copy intermediate
serialization results only once for broadcast mode
URL: https://github.com/apache/flink/pull/7713#discussion_r265990663
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/BroadcastRecordWriterTest.java
 ##########
 @@ -21,30 +21,30 @@
 import org.apache.flink.core.io.IOReadableWritable;
 
 Review comment:
   > And submit a hotfix PR separately for the fourth commit. 
   
   I'm fine with having hotfixes in one single PR
   
   > The third commit is just making the previous tests in RecordWriterTest work in the
way of BroadcastRecordWriter
   
   So the `BroadcastRecordWriterTest` added in the 2nd commit, doesn't actually test the `BroadcastRecordWriter`
until it's fixed in the 3rd commit? In that case definitely those two commits should be squashed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message