flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zhijiangW commented on a change in pull request #7911: [FLINK-11082][network] Fix the logic of getting backlog in sub partition
Date Fri, 15 Mar 2019 13:59:35 GMT
zhijiangW commented on a change in pull request #7911: [FLINK-11082][network] Fix the logic
of getting backlog in sub partition
URL: https://github.com/apache/flink/pull/7911#discussion_r265991992
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpilledSubpartitionView.java
 ##########
 @@ -147,7 +147,8 @@ public BufferAndBacklog getNextBuffer() throws IOException, InterruptedException
 			return null;
 		}
 
-		int newBacklog = parent.decreaseBuffersInBacklog(current.isBuffer());
+		parent.decreaseBuffersInBacklog(current.isBuffer());
+		int newBacklog = parent.getBuffersInBacklog();
 
 Review comment:
   I agree with your point of option 2. Based on the current implementation we could confirm
no problem, but it might leave risks if changing something in future. It is also easy to understand
for others in option 2.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message