flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] hequn8128 commented on issue #7976: [FLINK-11908][table] Port window classes into flink-api-java
Date Fri, 15 Mar 2019 14:34:51 GMT
hequn8128 commented on issue #7976: [FLINK-11908][table] Port window classes into flink-api-java
URL: https://github.com/apache/flink/pull/7976#issuecomment-473309642
 
 
   @twalthr Sorry. I missed the important messages from you. Convert the ExpressionParser
into an interface is a good solution. So we can port TumbleWithSize, TumbleWithSizeOnTime,
etc. directly into api-java. This also performs a reflection step at just one location. 
   
   Good idea! 
   I will try to update the PR asap.
   
   Best, Hequn

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message