flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] npav opened a new pull request #8026: [FLINK-5490] prevent ContextEnvironment#getExecutionPlan() from clear…
Date Wed, 20 Mar 2019 22:15:20 GMT
npav opened a new pull request #8026: [FLINK-5490] prevent ContextEnvironment#getExecutionPlan()
from clear…
URL: https://github.com/apache/flink/pull/8026
 
 
   …ing the sinks
   
   ## What is the purpose of the change
   
   This pull request prevents ContextEnvironment#getExecutionPlan() from clearing the sinks.
It allows for consecutive calls of ContextEnvironment#getExecutionPlan() or subsequent calls
of ContextEnvironment#getExecutionPlan() and ExecutionEnvironment#execute(), which isn't currently
possible because an exception about having no defined sinks is thrown.
   
   ## Brief change log
   
   * ContextEnvironment#getExecutionPlan() now calls ExecutionEnvironment#createProgramPlan()
with the clearSinks flag explicitly set to "false" (it defaults to "true" if not set)
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   * Added a unit test which performs two consecutive calls to ContextEnvironment#getExecutionPlan().
This test throws an exception if t he execution plan is cleared in-between calls. It is failing
with the current code and succeeding with this patch.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message