flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zhijiangW commented on a change in pull request #7911: [FLINK-11082][network] Fix the logic of getting backlog in sub partition
Date Tue, 26 Mar 2019 07:45:49 GMT
zhijiangW commented on a change in pull request #7911: [FLINK-11082][network] Fix the logic
of getting backlog in sub partition
URL: https://github.com/apache/flink/pull/7911#discussion_r268973121
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartition.java
 ##########
 @@ -115,52 +115,62 @@ protected Throwable getFailureCause() {
 
 	public abstract boolean isReleased();
 
+	public abstract boolean isFinished();
+
+	public abstract boolean isFlushRequested();
 
 Review comment:
   Could be `protected` as above.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message