flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] Myasuka commented on a change in pull request #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem
Date Thu, 28 Mar 2019 07:13:00 GMT
Myasuka commented on a change in pull request #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's
mistaken usage of default filesystem
URL: https://github.com/apache/flink/pull/8068#discussion_r269878198
 
 

 ##########
 File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksIncrementalSnapshotStrategy.java
 ##########
 @@ -209,7 +209,7 @@ private SnapshotDirectory prepareLocalSnapshotDirectory(long checkpointId)
throw
 			}
 		} else {
 			// create a "temporary" snapshot directory because local recovery is inactive.
-			Path path = new Path(instanceBasePath.getAbsolutePath(), "chk-" + checkpointId);
+			Path path = new Path(instanceBasePath.toURI().toString(), "chk-" + checkpointId);
 
 Review comment:
   Just a trivial modification, how about change this line to keep symmetrical to local-recovery-enabled
code?
   ~~~ java
   				File snapshotDir = new File(instanceBasePath, "chk-" + checkpointId);
   				Path path = new Path(snapshotDir.toURI());
   ~~~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message