flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "sunjincheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-11068) Convert the API classes *Table, *Window to interfaces
Date Thu, 14 Mar 2019 04:01:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-11068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792316#comment-16792316
] 

sunjincheng commented on FLINK-11068:
-------------------------------------

Hi, [~hequn8128] [~twalthr] , I also agree rename `Window` to `GroupWindow`, and I have a
soft spot for open a separate PRs. 

Here just a suggestion, how about we open a new PR for  Deprecated the Window in release-1.8,
since we should create a new RC2 for release 1.8.

What do you think?

> Convert the API classes *Table, *Window to interfaces
> -----------------------------------------------------
>
>                 Key: FLINK-11068
>                 URL: https://issues.apache.org/jira/browse/FLINK-11068
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / Table SQL
>            Reporter: Timo Walther
>            Assignee: Hequn Cheng
>            Priority: Major
>
> A more detailed description can be found in [FLIP-32|https://cwiki.apache.org/confluence/display/FLINK/FLIP-32%3A+Restructure+flink-table+for+future+contributions].
> This includes: Table, GroupedTable, WindowedTable, WindowGroupedTable, OverWindowedTable,
Window, OverWindow
> We can keep the "Table" Scala implementation in a planner module until it has been converted
to Java.
> We can add a method to the planner later to give us a concrete instance. This is one
possibility to have a smooth transition period instead of changing all classes at once.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message