flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Congxian Qiu(klion26) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (FLINK-11797) Implement empty unit tests in CheckpointCoordinatorMasterHooksTest
Date Sun, 03 Mar 2019 03:12:00 GMT

     [ https://issues.apache.org/jira/browse/FLINK-11797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Congxian Qiu(klion26) updated FLINK-11797:
------------------------------------------
    Description: 
Current, there are some empty tests(no implementation) such as {{testSerializationFailsOnTrigger, }}{{testHookCallFailsOnTrigger, }}{{testDeserializationFailsOnRestore}}{{testHookCallFailsOnRestore, }}{{testTypeIncompatibleWithSerializerOnStore
and }}{{testTypeIncompatibleWithHookOnRestore in class }}{{CheckpointCoordinatorMasterHooksTest[1].}}

If implement them make sense, I'll give the patch.

[1] [https://github.com/apache/flink/blob/e3248d844c728c714857c5d69520f08ddf4e4c85/flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorMasterHooksTest.java#L393]

  was:
Current, there are some empty tests(no implementation) such as {{testSerializationFailsOnTrigger, }}{{testHookCallFailsOnTrigger, }}{{testDeserializationFailsOnRestore}}{{testHookCallFailsOnRestore, }}{{testTypeIncompatibleWithSerializerOnStore
and }}{{testTypeIncompatibleWithHookOnRestore in class }}{{CheckpointCoordinatorMasterHooksTest[1].}}

If implementation them make sense, I'll give the patch.

[1] [https://github.com/apache/flink/blob/e3248d844c728c714857c5d69520f08ddf4e4c85/flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorMasterHooksTest.java#L393]


> Implement empty unit tests in CheckpointCoordinatorMasterHooksTest
> ------------------------------------------------------------------
>
>                 Key: FLINK-11797
>                 URL: https://issues.apache.org/jira/browse/FLINK-11797
>             Project: Flink
>          Issue Type: Test
>          Components: Tests
>    Affects Versions: 1.8.0
>            Reporter: Congxian Qiu(klion26)
>            Assignee: Congxian Qiu(klion26)
>            Priority: Major
>
> Current, there are some empty tests(no implementation) such as {{testSerializationFailsOnTrigger, }}{{testHookCallFailsOnTrigger, }}{{testDeserializationFailsOnRestore}}{{testHookCallFailsOnRestore, }}{{testTypeIncompatibleWithSerializerOnStore
and }}{{testTypeIncompatibleWithHookOnRestore in class }}{{CheckpointCoordinatorMasterHooksTest[1].}}
> If implement them make sense, I'll give the patch.
> [1] [https://github.com/apache/flink/blob/e3248d844c728c714857c5d69520f08ddf4e4c85/flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorMasterHooksTest.java#L393]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message