flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dawid Wysakowicz (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (FLINK-11867) mistaking in checking filePath's value
Date Mon, 11 Mar 2019 14:30:00 GMT

     [ https://issues.apache.org/jira/browse/FLINK-11867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dawid Wysakowicz closed FLINK-11867.
------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.8.0
                   1.7.3

Fixed in:
master via 2995ca16e4feef717343859248ba5992e6813c61
1.8.0: 37879f70529b3574608539b92cedb9de338a2e66
1.7.3: a93381360c06a67cd8dca16e3fb5df228c7a63bf

> mistaking in checking filePath's value
> --------------------------------------
>
>                 Key: FLINK-11867
>                 URL: https://issues.apache.org/jira/browse/FLINK-11867
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Tom Goong
>            Assignee: Tom Goong
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.3, 1.8.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In class StreamExecutionEnvironment
>  
> {code:java}
> // code placeholder
> public DataStreamSource<String> readTextFile(String filePath, String charsetName)
{
> Preconditions.checkNotNull(filePath, "The file path must not be null.");
> Preconditions.checkNotNull(filePath.isEmpty(), "The file path must not be empty.");
> TextInputFormat format = new TextInputFormat(new Path(filePath));
> format.setFilesFilter(FilePathFilter.createDefaultFilter());
> TypeInformation<String> typeInfo = BasicTypeInfo.STRING_TYPE_INFO;
> format.setCharsetName(charsetName);
> return readFile(format, filePath, FileProcessingMode.PROCESS_ONCE, -1, typeInfo);
> }
> {code}
>  
> the *Preconditions.checkNotNull(filePath.isEmpty(), "The file path must not be empty.");*
this will not work



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message