flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zjuwangg commented on a change in pull request #9689: [FLINK-7151] add a basic function ddl
Date Tue, 08 Oct 2019 03:20:26 GMT
zjuwangg commented on a change in pull request #9689: [FLINK-7151] add a basic function ddl
URL: https://github.com/apache/flink/pull/9689#discussion_r332322049
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java
 ##########
 @@ -316,6 +316,35 @@ public void dropTable(ObjectIdentifier objectIdentifier, boolean ignoreIfNotExis
 			"DropTable");
 	}
 
+	/**
+	 * Create a function in a given fully qualified path.
+	 *
+	 * @param catalogFunction  The function to put in the given path
+	 * @param objectIdentifier
+	 * @param ignoreIfExists
 
 Review comment:
   It's better to add comments to explain arguments meaning. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message