flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] wsry commented on issue #9758: [FLINK-14185][tests]Move unstable assertion statement out of close method of QS test server.
Date Tue, 08 Oct 2019 03:48:09 GMT
wsry commented on issue #9758: [FLINK-14185][tests]Move unstable assertion statement out of
close method of QS test server.
URL: https://github.com/apache/flink/pull/9758#issuecomment-539302270
 
 
   > What if we didn't share the stats between servers?
   
   @zentol From the previous comment and assertion statement below,
   ```
   // the client connects to both servers and the stats object is shared.
   Assert.assertEquals(2L, serverStats.getNumConnections());
   ```
   I guess that the test case makes the assumption of shared stats, though, which can also
be changed.
   Which way of fix do you prefer? Don't share stats and change the above assertion to
   ```
   Assert.assertEquals(1L, serverStats.getNumConnections());
   ```
   or move the unstable assertion statement out of close method as what this pr does. Both
are acceptable for me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message