flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] sunjincheng121 commented on a change in pull request #9748: [FLINK-14016][python][flink-table-planner] Introduce DataStreamPythonCalc for Python function execution
Date Tue, 08 Oct 2019 04:45:42 GMT
sunjincheng121 commented on a change in pull request #9748: [FLINK-14016][python][flink-table-planner]
Introduce DataStreamPythonCalc for Python function execution
URL: https://github.com/apache/flink/pull/9748#discussion_r332333999
 
 

 ##########
 File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/FunctionDefinition.java
 ##########
 @@ -40,6 +40,13 @@
 	 */
 	FunctionKind getKind();
 
+	/**
+	 * Returns the language of function this definition describes.
+	 */
+	default FunctionLanguage getLanguage() {
 
 Review comment:
   +1. If we add the `PythonFunction` interface for Python, I think `getLanguage()` can be
removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message