flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] hequn8128 commented on a change in pull request #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage.
Date Mon, 14 Oct 2019 12:39:21 GMT
hequn8128 commented on a change in pull request #9894: [FLINK-14342][table][python] Remove
method FunctionDefinition#getLanguage.
URL: https://github.com/apache/flink/pull/9894#discussion_r334452358
 
 

 ##########
 File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/plan/ExpressionReductionRulesTest.scala
 ##########
 @@ -529,11 +530,13 @@ object DeterministicNullFunc extends ScalarFunction {
   override def isDeterministic = true
 }
 
-object DeterministicPythonFunc extends ScalarFunction {
-
-  override def getLanguage: FunctionLanguage = FunctionLanguage.PYTHON
+object DeterministicPythonFunc extends ScalarFunction with PythonFunction{
 
 Review comment:
   Add a blank after the `PythonFunction`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message