flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] pnowojski commented on a change in pull request #9772: [FLINK-14199] Only use dedicated/named classes for mailbox letters.
Date Tue, 15 Oct 2019 12:16:05 GMT
pnowojski commented on a change in pull request #9772: [FLINK-14199] Only use dedicated/named
classes for mailbox letters. 
URL: https://github.com/apache/flink/pull/9772#discussion_r328465893
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/Emitter.java
 ##########
 @@ -89,13 +91,10 @@ public void run() {
 			while (running) {
 				LOG.debug("Wait for next completed async stream element result.");
 				AsyncResult asyncResult = streamElementQueue.peekBlockingly();
-				executor.submit(() -> {
-					try {
-						output(asyncResult);
-					} catch (InterruptedException e) {
-						Thread.currentThread().interrupt();
-					}
-				}).get();
+				executor.submit(namedCallable(() -> {
+					output(asyncResult);
+					return true;
+				}, "AsyncWaitOperator/Emitter")).get();
 
 Review comment:
   nit: formatting 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message