flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] hequn8128 commented on a change in pull request #9894: [FLINK-14342][table][python] Remove method FunctionDefinition#getLanguage.
Date Wed, 16 Oct 2019 03:08:59 GMT
hequn8128 commented on a change in pull request #9894: [FLINK-14342][table][python] Remove
method FunctionDefinition#getLanguage.
URL: https://github.com/apache/flink/pull/9894#discussion_r335258634
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/PythonUtil.scala
 ##########
 @@ -29,40 +30,42 @@ object PythonUtil {
     * Checks whether it contains the specified kind of function in the specified node.
     *
     * @param node the RexNode to check
-    * @param language the expected kind of function to find
+    * @param findPythonFunction true to find python function, false to find java function
 
 Review comment:
   java function => non-python function? This doesn't have to be java. Same for the comments
of FunctionFinder.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message