flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] hequn8128 commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF
Date Wed, 16 Oct 2019 08:17:20 GMT
hequn8128 commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink]
Support Blink planner for Python UDF
URL: https://github.com/apache/flink/pull/9890#discussion_r335317308
 
 

 ##########
 File path: flink-python/pyflink/table/tests/test_udf.py
 ##########
 @@ -15,13 +15,22 @@
 #  See the License for the specific language governing permissions and
 # limitations under the License.
 ################################################################################
+from abc import ABCMeta
+
 from pyflink.table import DataTypes
 from pyflink.table.udf import ScalarFunction, udf
 from pyflink.testing import source_sink_utils
-from pyflink.testing.test_case_utils import PyFlinkStreamTableTestCase
+from pyflink.testing.test_case_utils import PyFlinkStreamTableTestCase, \
+    PyFlinkBlinkStreamTableTestCase, PyFlinkBlinkBatchTableTestCase
 
 
-class UserDefinedFunctionTests(PyFlinkStreamTableTestCase):
+class UserDefinedFunctionTests:
+    """
+    The abstract base class for PyFlinkStreamUserDefinedFunctionTests,
+    PyFlinkBatchUserDefinedFunctionTests, PyFlinkBlinkStreamUserDefinedFunctionTests
 
 Review comment:
   Remove PyFlinkBatchUserDefinedFunctionTests. We have not supported batch mode for flink
planner yet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message