flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] wuchong commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional for optional parameters in parser module
Date Wed, 16 Oct 2019 08:25:27 GMT
wuchong commented on a change in pull request #9843: [FLINK-14296] [Table SQL] Use Optional
for optional parameters in parser module
URL: https://github.com/apache/flink/pull/9843#discussion_r335338458
 
 

 ##########
 File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
 ##########
 @@ -129,7 +133,7 @@ public boolean isIfNotExists() {
 
 	public void validate() throws SqlValidateException {
 		Set<String> columnNames = new HashSet<>();
-		if (columnList != null) {
+		if (columnList.size() > 0) {
 
 Review comment:
   +1 to remove it. It is useless.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message