flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] hequn8128 commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink] Support Blink planner for Python UDF
Date Thu, 17 Oct 2019 09:32:04 GMT
hequn8128 commented on a change in pull request #9890: [FLINK-14272][python][table-planner-blink]
Support Blink planner for Python UDF
URL: https://github.com/apache/flink/pull/9890#discussion_r335903439

 File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/batch/table/BatchPythonScalarFunctionSplitRuleTest.scala
 @@ -0,0 +1,136 @@
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.table.planner.plan.batch.table
+import org.apache.flink.api.common.typeinfo.{BasicTypeInfo, TypeInformation}
+import org.apache.flink.api.scala._
+import org.apache.flink.table.api.scala._
+import org.apache.flink.table.functions.{FunctionLanguage, ScalarFunction}
+import org.apache.flink.table.planner.utils.TableTestBase
+import org.junit.Test
+class BatchPythonScalarFunctionSplitRuleTest extends TableTestBase {
 Review comment:
   Maybe we can rename it to PythonCalcTest and add this PythonScalarFunctionSplitRuleTest
in the rules/logical. The PythonCalcTest is used to test `BatchExecPythonCalcRule` and the
whole optimization phase while PythonScalarFunctionSplitRuleTest is used to test the `PythonScalarFunctionSplitRule`.
   In other words, we will have three tests, i.e., two PythonCalcTest(one for batch and one
for stream), one PythonScalarFunctionSplitRuleTest

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message