flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zentol commented on a change in pull request #9759: [FLINK-14169][history-server] Cleanup expired jobs from history server
Date Fri, 18 Oct 2019 13:23:39 GMT
zentol commented on a change in pull request #9759: [FLINK-14169][history-server] Cleanup expired
jobs from history server
URL: https://github.com/apache/flink/pull/9759#discussion_r336479097
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/configuration/HistoryServerOptions.java
 ##########
 @@ -89,6 +89,16 @@
 			.withDescription("Enable HTTPs access to the HistoryServer web frontend. This is applicable
only when the" +
 				" global SSL flag security.ssl.enabled is set to true.");
 
+	/**
+	 * Specifies whether the HistoryServer should process job archive deletion. If this option
is
 
 Review comment:
   I'd omit the first sentence, `process job archive deletion` is quite broad, and only really
makes _sense_ after the second sentence.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message