flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] bowenli86 commented on a change in pull request #9927: [FLINK-14397][hive] Failed to run Hive UDTF with array arguments
Date Mon, 21 Oct 2019 16:43:07 GMT
bowenli86 commented on a change in pull request #9927: [FLINK-14397][hive] Failed to run Hive
UDTF with array arguments
URL: https://github.com/apache/flink/pull/9927#discussion_r337119905
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogDataTypeTest.java
 ##########
 @@ -177,7 +178,7 @@ public void testComplexDataTypes() throws Exception {
 			DataTypes.ROW(
 				DataTypes.FIELD("0", DataTypes.BOOLEAN()),
 				DataTypes.FIELD("1", DataTypes.BOOLEAN()),
-				DataTypes.FIELD("2", DataTypes.DATE())),
+				DataTypes.FIELD("2", HiveTypeUtil.HIVE_DATE_TYPE)),
 
 Review comment:
   This seems not very user friendly because now users are supposed to know this extra static
member HiveTypeUtil.HIVE_DATE_TYPE besides DataTypes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message