flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] hequn8128 commented on a change in pull request #9977: [FLINK-14497][python] Support primitive data types in Python user-defined functions
Date Thu, 24 Oct 2019 06:19:11 GMT
hequn8128 commented on a change in pull request #9977: [FLINK-14497][python] Support primitive
data types in Python user-defined functions
URL: https://github.com/apache/flink/pull/9977#discussion_r338368446
 
 

 ##########
 File path: flink-python/src/main/java/org/apache/flink/table/runtime/typeutils/BeamTypeUtils.java
 ##########
 @@ -64,207 +73,237 @@
 
 	private static final String EMPTY_STRING = "";
 
-	public static Coder toCoder(LogicalType logicalType) {
-		return logicalType.accept(new LogicalTypeToCoderConverter());
+	public static TypeSerializer toFlinkTypeSerializer(LogicalType logicalType) {
 
 Review comment:
   How about renaming this class name to `PythonTypeUtils`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message