flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] TisonKun commented on a change in pull request #10010: [FLINK-10435][yarn]Client sporadically hangs after Ctrl + C
Date Tue, 29 Oct 2019 02:16:55 GMT
TisonKun commented on a change in pull request #10010: [FLINK-10435][yarn]Client sporadically
hangs after Ctrl + C
URL: https://github.com/apache/flink/pull/10010#discussion_r339868479
 
 

 ##########
 File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
 ##########
 @@ -1241,7 +1241,6 @@ private void failSessionDuringDeployment(YarnClient yarnClient, YarnClientApplic
 			// call (we don't know if the application has been deployed when the error occured).
 			LOG.debug("Error while killing YARN application", e);
 		}
-		yarnClient.stop();
 
 Review comment:
   I can see other caller of `failSessionDuringDeployment` such as L525 and L511. Why do you
remove this line. IIUC now we don't stop yarnClient in these two cases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message