flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for Table transformations
Date Tue, 29 Oct 2019 16:40:46 GMT
walterddr commented on a change in pull request #9373: [FLINK-13596][ml] Add two utils for
Table transformations
URL: https://github.com/apache/flink/pull/9373#discussion_r340193149

 File path: flink-ml-parent/flink-ml-lib/src/main/java/org/apache/flink/ml/common/utils/RowTypeDataStream.java
 @@ -0,0 +1,157 @@
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.flink.ml.common.utils;
+import org.apache.flink.api.common.functions.MapFunction;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.java.typeutils.RowTypeInfo;
+import org.apache.flink.ml.common.MLEnvironment;
+import org.apache.flink.ml.common.MLEnvironmentFactory;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+ * Provide functions of conversions between DataStream and Table.
+ */
+public class RowTypeDataStream {
+	/**
+	 * Convert the given Table to {@link DataStream DataStream&lt;Row&gt;}.
+	 *
+	 * @param sessionId the sessionId of {@link MLEnvironmentFactory}
+	 * @param table the Table to convert.
+	 * @return the converted DataStream.
+	 */
+	public static DataStream <Row> fromTable(Long sessionId, Table table) {
 Review comment:
   nit: If we rename these two APIs to `convertToDataStream` & `convertToDataSet` we can
probably combine the two files. since `MLEnvironment` encapsulates both Batch and Stream envs.
it is also consistent IMO.
   I am fine with keeping two files and separate these APIs as well. maybe some other folks
can provide some feedbacks on this.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message