flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] bowenli86 commented on a change in pull request #9998: [FLINK-14534][table] FunctionCatalog.getUserDefinedFunctions() should include temp functions
Date Tue, 29 Oct 2019 17:18:39 GMT
bowenli86 commented on a change in pull request #9998: [FLINK-14534][table] FunctionCatalog.getUserDefinedFunctions()
should include temp functions
URL: https://github.com/apache/flink/pull/9998#discussion_r340215937
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionCatalog.java
 ##########
 @@ -209,20 +209,23 @@ public void registerTempCatalogScalarFunction(ObjectIdentifier oi,
ScalarFunctio
 	private Set<String> getUserDefinedFunctionNames() {
 		Set<String> result = new HashSet<>();
 
-		// Get functions in catalog
+		// add temp system functions
+		result.addAll(tempSystemFunctions.keySet());
+
+		// add temp catalog functions
+		result.addAll(tempCatalogFunctions.keySet().stream()
 
 Review comment:
   right

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message