flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] lqjack commented on a change in pull request #15812: remove slotpoolImpl
Date Fri, 07 May 2021 15:49:29 GMT

lqjack commented on a change in pull request #15812:
URL: https://github.com/apache/flink/pull/15812#discussion_r628328869



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolInteractionsTest.java
##########
@@ -18,6 +18,8 @@
 
 package org.apache.flink.runtime.jobmaster.slotpool;
 
+import com.google.common.collect.Lists;

Review comment:
       OK

##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java
##########
@@ -97,8 +103,10 @@ private void executeOperationForAllExecutions(
         }
     }
 
-    private SlotPoolImpl createSlotPoolImpl() {
-        return new TestingSlotPoolImpl(TEST_JOB_ID);
+    private SlotPool createSlotPoolImpl() {
+        return new DeclarativeSlotPoolBridgeServiceFactory(SystemClock.getInstance(), DEFAULT_RPC_TIME_OUT,
DEFAULT_IDLE_SLOT_TIME_OUT, DEFAULT_BATCH_TIME_OUT).createSlotPoolService(TEST_JOB_ID).castInto(SlotPool.class).orElseThrow(()
->
+                new IllegalStateException(
+                        "The AdaptiveScheduler requires a DeclarativeSlotPool."));

Review comment:
       Got it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message