flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zentol commented on a change in pull request #15883: [FLINK-22556][ci] Extend JarFileChecker to search for traces of incompatible licenses
Date Tue, 11 May 2021 07:32:08 GMT

zentol commented on a change in pull request #15883:
URL: https://github.com/apache/flink/pull/15883#discussion_r629917181



##########
File path: tools/ci/java-ci-tools/src/main/java/org/apache/flink/tools/ci/licensecheck/JarFileChecker.java
##########
@@ -134,6 +140,91 @@ private static boolean licenseFileExistsAndIsValid(Path licenseFile,
Path jar)
         return true;
     }
 
+    private static int getFilesWithIncompatibleLicenses(Path jar, Path jarRoot) throws IOException
{
+        return findNonBinaryFilesContainingText(
+                jar,
+                jarRoot,
+                asPatterns(
+                        "GNU Lesser General Public License",
+                        "GNU General Public License",
+                        "GPL", // also detects LGPL
+                        "GNU Affero General Public License",
+                        "Amazon Software License",
+                        "Confluent Community License Agreement Version 1.0",
+                        "Don’t be evil") // can sometimes be found in "funny" licenses

Review comment:
       Ill look into it
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message