flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink-statefun] tzulitai commented on pull request #231: [FLINK-22554] Add topic subscription to KafkaIngress
Date Tue, 11 May 2021 08:04:54 GMT

tzulitai commented on pull request #231:
URL: https://github.com/apache/flink-statefun/pull/231#issuecomment-838033210


   I took a pass over the implementation, and while this would work I'm wondering about how
useful this feature would be with the current way of how things work.
   
   With this PR, we are enabling routing topics that match a specific pattern to a static
set of functions.
   I believe the value of this feature really shines when, we add a new function to the topology,
and would like it to receive events from a new Kafka topic as well. This is not enabled by
the proposal in this PR.
   
   If there is already a use case out there that could make use of this PR, I'm fine to merge
this, but if not, I'd prefer to take a step back and think if we can address this by looking
at a more macro scope of the dynamic functions story.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message