flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] lirui-apache commented on a change in pull request #15810: [FLINK-22534] Set delegation token's service name as credential alias
Date Tue, 11 May 2021 09:10:59 GMT

lirui-apache commented on a change in pull request #15810:
URL: https://github.com/apache/flink/pull/15810#discussion_r629984964



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/security/modules/HadoopModule.java
##########
@@ -97,8 +97,7 @@ public void install() throws SecurityInstallException {
                     // If UGI use keytab for login, do not load HDFS delegation token.
                     for (Token<? extends TokenIdentifier> token : usrTok) {
                         if (!token.getKind().equals(hdfsDelegationTokenKind)) {
-                            final Text id = new Text(token.getIdentifier());
-                            credentialsToBeAdded.addToken(id, token);
+                            credentialsToBeAdded.addToken(token.getService(), token);

Review comment:
       Could you explain why we don't need the deep copy as the alias any more(or why we needed
it before)?
   
   I'd prefer to avoid such subtle changes especially since HDFS-9276 also introduced some
deep copy constructor: https://issues.apache.org/jira/browse/HDFS-9276?focusedCommentId=15391195&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15391195




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message