flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] lirui-apache commented on pull request #15920: [FLINK-22661][hive] HiveInputFormatPartitionReader can return invalid…
Date Thu, 20 May 2021 04:11:19 GMT

lirui-apache commented on pull request #15920:
URL: https://github.com/apache/flink/pull/15920#issuecomment-844671552


   > Thanks @lirui-apache for the contribution, LGTM.
   > The bug also exists in single split and the test you used to mock reader for lookup
also is single split. It will be great if you can update the PR description.
   
   Hi @leonardBang , thanks for reviewing. I don't think single split has issue. The test
I add uses multiple splits. Note that in `prepareData` I run INSERT twice so that at least
two files are generated. Since we don't combine splits, there will be at least two splits
to read.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message