flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] wuchong commented on a change in pull request #15944: [FLINK-22694][e2e] Use sql file in TPCH end to end tests
Date Thu, 20 May 2021 04:38:20 GMT

wuchong commented on a change in pull request #15944:
URL: https://github.com/apache/flink/pull/15944#discussion_r635740045



##########
File path: flink-end-to-end-tests/test-scripts/test_tpch.sh
##########
@@ -51,29 +51,27 @@ ORIGIN_QUERY_DIR="$TARGET_DIR/query"
 MODIFIED_QUERY_DIR="$TPCH_DATA_DIR/modified-query"
 EXPECTED_DIR="$TARGET_DIR/expected"
 RESULT_DIR="$TEST_DATA_DIR/result"
-SQL_CONF="$TEST_DATA_DIR/sql-client-session.conf"
+INIT_SQL="$TEST_DATA_DIR/init_table.sql"
 
 mkdir "$RESULT_DIR"
 
-SOURCES_YAML=$(cat "$TPCH_DATA_DIR/source.yaml")
-SOURCES_YAML=${SOURCES_YAML//\$TABLE_DIR/"$TABLE_DIR"}
+SOURCES_SQL=$(cat "$TPCH_DATA_DIR/source.sql")
+SOURCES_SQL=${SOURCES_SQL//\$TABLE_DIR/"$TABLE_DIR"}
 
 for i in {1..22}
 do
     echo "Running query #$i..."
 
     # First line in sink yaml is ignored

Review comment:
       update the comment. 

##########
File path: flink-end-to-end-tests/flink-tpch-test/src/main/java/org/apache/flink/table/tpch/TpchResultComparator.java
##########
@@ -81,7 +93,10 @@ public static void main(String[] args) throws IOException {
                                 failed = (e * 0.99 > t || e * 1.01 < t);
                             }
                         } catch (NumberFormatException nfe2) {
-                            failed = !expected[i].trim().equals(actual[i].trim());
+                            failed =
+                                    !expected[i]
+                                            .trim()
+                                            .equals(actual[i].replaceAll("\"", "").trim());

Review comment:
       Why there are quotes on numeric?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message