flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] wangwei1025 commented on a change in pull request #15939: [FLINK-15390][Connectors/ORC][Connectors/Hive]List/Map/Struct types support for vectorized orc reader
Date Fri, 28 May 2021 10:36:53 GMT

wangwei1025 commented on a change in pull request #15939:
URL: https://github.com/apache/flink/pull/15939#discussion_r640348545



##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/data/ColumnarMapData.java
##########
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.data;
+
+import org.apache.flink.table.data.vector.ColumnVector;
+
+/** Columnar map to support access to vector column data. */
+public final class ColumnarMapData implements MapData {
+
+    private final ColumnVector keyColumnVector;
+    private final ColumnVector valueColumnVector;
+    private final int offset;
+    private final int numElements;
+
+    public ColumnarMapData(
+            ColumnVector keyColumnVector,
+            ColumnVector valueColumnVector,
+            int offset,
+            int numElements) {
+        this.keyColumnVector = keyColumnVector;
+        this.valueColumnVector = valueColumnVector;
+        this.offset = offset;
+        this.numElements = numElements;
+    }
+
+    @Override
+    public int size() {
+        return numElements;
+    }
+
+    @Override
+    public ArrayData keyArray() {
+        return new ColumnarArrayData(keyColumnVector, offset, numElements);
+    }
+
+    @Override
+    public ArrayData valueArray() {
+        return new ColumnarArrayData(valueColumnVector, offset, numElements);
+    }
+
+    @Override
+    public boolean equals(Object o) {
+        throw new UnsupportedOperationException(

Review comment:
       I don't support _equals_ and _hashCode_ because ColumnarRowData don't support it either.
And I think it's appropriate because  ColumnarRowData don't actually decode data from vector
before reading data.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message