flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] cmick commented on a change in pull request #16023: [FLINK-22698][connectors/rabbitmq] Add deliveryTimeout parameter to RabbitMQ source
Date Sun, 30 May 2021 21:32:23 GMT

cmick commented on a change in pull request #16023:
URL: https://github.com/apache/flink/pull/16023#discussion_r642131205



##########
File path: flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java
##########
@@ -322,14 +323,28 @@ private void processMessage(Delivery delivery, RMQCollectorImpl collector)
throw
         deliveryDeserializer.deserialize(envelope, properties, body, collector);
     }
 
+    /**
+     * Returns the next message delivery timeout used in the queueing consumer. If not specified
in
+     * the provided connection config, the default value of 30000 milliseconds will be returned.
+     *
+     * @return consumer delivery timeout in milliseconds
+     */
+    protected int getDeliveryTimeout() {
+        return rmqConnectionConfig.getDeliveryTimeout().orElse(DEFAULT_DELIVERY_TIMEOUT);

Review comment:
       Thanks. I've moved the default value setting to `RMQConnectionConfig` (14571a9)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message