flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Rohrmann (Jira)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-22721) Breaking HighAvailabilityServices interface by adding new method
Date Thu, 20 May 2021 08:45:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-22721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348155#comment-17348155
] 

Till Rohrmann commented on FLINK-22721:
---------------------------------------

The short answer is yes. We noticed the breaking behavior with the vvp-ha service implementation.
I think it is worthwhile trying to be as compatible as possible since the default method won't
hurt us much.

> Breaking HighAvailabilityServices interface by adding new method
> ----------------------------------------------------------------
>
>                 Key: FLINK-22721
>                 URL: https://issues.apache.org/jira/browse/FLINK-22721
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination
>    Affects Versions: 1.14.0, 1.13.1, 1.12.5
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Critical
>             Fix For: 1.14.0, 1.13.1, 1.12.5
>
>
> As part of FLINK-20695 we introduced a new method to the {{HighAvailabilityServices.cleanupJobData}}
interface. Since this method has not default implementation it is currently breaking change.
Since Flink allows to implement custom Ha services using this interface, I suggest adding
a default implementation for this method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message