flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] echauchot opened a new pull request #15436: [FLINK-6417] Glob support for FileInputFormat
Date Thu, 06 May 2021 10:18:48 GMT

echauchot opened a new pull request #15436:
URL: https://github.com/apache/flink/pull/15436


   
   ## What is the purpose of the change
   
   Add support for glob (* in file name) for FileInputFormat so that it could profit for DataSet,
SQL and Table API.
   
   
   ## Brief change log
   
   Leverage existing GlobFilePathFilter to support globs without user configuration. 
   
   Sure, the user could call _FileInputFormat#setFileFilter()_ but it should not have to.
The glob should be supported with no required configuration. 
   
   And also, for some APIs (SQL for example) the FileInputFormat is used under the woods but
it is not part of the public API so the user cannot configure it. So he cannot use globs when
using this API. Supporting globs at the FileInputFormat level allows to have glob support
for all the APIs that rely on it.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   FileInputFormatTest#testGlobs()
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? the ticket says new feature, but I would have
qualified it as a bug as glob support is to be expected from every file access in big data
environments IMHO. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message