flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] zentol opened a new pull request #15975: [FLINK-22646][coordination] SlotManagers unregister metrics in suspend()
Date Thu, 20 May 2021 12:24:06 GMT

zentol opened a new pull request #15975:
URL: https://github.com/apache/flink/pull/15975


   Modified version of #15904.
   
   
   
   Slotmanagers register metrics in start(), but only unregister them in close().
   
   This has 2 issues:
   
   a) If the SM is restarted it cannot re-register the metrics because the old ones are still
present; this isn't a critical problem (because the old ones still work) but it produces unnecessary
logging noise
   
   b) The metric may produce an NPE when accessed by a reporter during suspend().
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message