flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flink] beyond1920 opened a new pull request #16025: [FLINK-22714][table-planner-blink] Simplify window TVF to a simple window assigner if successor node is WindowRank or WindowJoin.
Date Mon, 31 May 2021 04:13:24 GMT

beyond1920 opened a new pull request #16025:
URL: https://github.com/apache/flink/pull/16025

   ## What is the purpose of the change
   In theory, `StreamPhysicalWindowTableFunction` should works as a window assigner and emits
at ends of window. However, `StreamPhysicalWindowTableFunction` could be simplified to a simple
window assigner, and emits per record if it's successor node is one of `WindowRank`/`WindowJoin`/`WindowAggregate`
with `WindowAttachedWindowingStrategy`, because those nodes would assign input records to
windows have been assigned in input nodes, and trigger emit at ends of window.
   Besides, we should add a limit that window is based on rowtime, because it has syntax problem
if window is assigned based on the proc-time of previous operator.
   The pr introduce a rule to simplify window-tvf.
   ## Brief change log
     - Introduce `SimplifyWindowTableFunctionRule`
     - Add a flag in `StreamPhysicalWindowTableFunction` to specify whether it is a simplify
window tvf.
   ## Verifying this change
     - existed UT in `WindowRankTest` and `WindowJoinTest`
   ## Does this pull request potentially affect one of the following parts:
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   ## Documentation
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message