giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GIRAPH-238) BasicVertex should have default Writable implementation
Date Fri, 06 Jul 2012 16:13:36 GMT

    [ https://issues.apache.org/jira/browse/GIRAPH-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408114#comment-13408114
] 

Alessandro Presta commented on GIRAPH-238:
------------------------------------------

Just to be clear: implementors can still override those two methods, for example if their
vertices have no edge values, or if the edge list is implicit.
These provide a standard implementation that should suffice for most use cases.
We can probably start removing the overrides from some of the derived classes, either here
or in a later patch.
                
> BasicVertex should have default Writable implementation
> -------------------------------------------------------
>
>                 Key: GIRAPH-238
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-238
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>            Reporter: Alessandro Presta
>            Assignee: Alessandro Presta
>         Attachments: GIRAPH-238.patch
>
>
> It's good to give the option to optimize serialization, but nothing prevents us from
having default readFields()/write() methods in BasicVertex.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message