giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alessandro Presta (JIRA)" <>
Subject [jira] [Commented] (GIRAPH-221) Make iteration over edges more explicit
Date Sun, 01 Jul 2012 15:30:51 GMT


Alessandro Presta commented on GIRAPH-221:

@Avery: Regarding naming: one might object that we're not really returning edges here, so
a legitimate alternative could be getNeighborsIterator() or something like that.
I have a few ideas on how the API could be further rationalized but I'll save those for another

@Hyunsik: I brought up that same issue on the dev mailing list. I have a patch ready that
would make the order of imports uniform across the codebase and introduce checkstyle rules.
I'll open up an issue so we can discuss/vote on it.
> Make iteration over edges more explicit
> ---------------------------------------
>                 Key: GIRAPH-221
>                 URL:
>             Project: Giraph
>          Issue Type: Improvement
>          Components: graph
>            Reporter: Alessandro Presta
>            Assignee: Alessandro Presta
>            Priority: Minor
>         Attachments: GIRAPH-221-1.patch, GIRAPH-221-2.patch
> Is there any particular reason why BasicVertex implements Iterable?
> It seems to me that doing
> {code:java}
> for (I neighbor : vertex)
> {code}
> is not that explicit, and
> {code:java}
> for (I neighbor : this)
> {code}
> gets even obscure (which may be why all examples in the codebase explicitly instantiate
an iterator and call next()).
> What I propose is a more explicit
> {code:java}
> Iterator<I> outEdgesIterator()
> {code}
> and also a convenient
> {code:java}
> Iterable<I> outEdges()
> {code}
> so, for example, an algorithm can use
> {code:java}
> for (IntWritable neighbor : outEdges())
> {code}

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message