giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlogothetis <...@git.apache.org>
Subject [GitHub] giraph pull request #87: Better exception handling for large number of edges...
Date Mon, 15 Oct 2018 20:18:53 GMT
Github user dlogothetis commented on a diff in the pull request:

    https://github.com/apache/giraph/pull/87#discussion_r225302450
  
    --- Diff: giraph-core/src/main/java/org/apache/giraph/edge/ByteArrayEdges.java ---
    @@ -94,6 +94,9 @@ public void add(Edge<I, E> edge) {
         } catch (IOException e) {
           throw new IllegalStateException("add: Failed to write to the new " +
               "byte array");
    +    } catch (NegativeArraySizeException negativeArraySizeException) {
    +      throw new IllegalStateException("add: Too many edges for a vertex, " +
    --- End diff --
    
    Could we add the ID of the vertex in the exception message? It may be useful for debugging
purposes.


---

Mime
View raw message