giraph-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [giraph] atanu1991 commented on a change in pull request #150: GIRAPH-1251: Add optional SSLHandler for all Netty Communication
Date Fri, 14 May 2021 21:02:59 GMT

atanu1991 commented on a change in pull request #150:
URL: https://github.com/apache/giraph/pull/150#discussion_r632746533



##########
File path: giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java
##########
@@ -325,6 +327,12 @@ public NettyClient(Mapper<?, ?, ?, ?>.Context context,
       executionGroup = null;
     }
 
+    if (conf.sslAuthenticate()) {
+      nettySSLHandler = new NettySSLHandler(true, conf);
+    } else {
+      nettySSLHandler = null;
+    }

Review comment:
       Compile complains :)
   Final variables needs to be initalized.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message