gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lewis John McGibbney (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (GORA-103) Datastore for gora-dynamodb
Date Fri, 07 Sep 2012 10:54:08 GMT

    [ https://issues.apache.org/jira/browse/GORA-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450516#comment-13450516
] 

Lewis John McGibbney edited comment on GORA-103 at 9/7/12 9:53 PM:
-------------------------------------------------------------------

Hi Ferdy,
Thanks for the comments. As usual great. Please see my replies.

1) No log4j.properties being changed to DEBUG is a mistake on our side. This will be reverted
to INFO in the forthcoming patch
2) To explain why Persistent is changed to PersistentBase I refer you to bullet point 4 in
the 3rd project report. E.g. "4. The class diagram showed below explains the changes done
inside Gora's core. The main change is the separation of Avro as persistency layer and an
actual abstract persistency layer. This needed to be done to allow web based datastores such
as [3, 4] to be part of Gora, and to allow developers to use popular datastores. 
This “new” abstract interface is “Persistent.java” from org.apache.gora.persistency.
It is the same interface as before but this does not extend from Avro anymore which makes
it the perfect start point for different abstractions that other datastores might need. Now
all the specific abstraction classes are inside their specific packages e.g. the org.apache.gora.persistency.impl
contains all the abstract classes which are file based datastores such as Cassandra, HBase,
among others. And the org.apache.gora.persistency.ws.impl package contains all the abstract
classes which are web service based datastores such as DynamoDB, Google's AppEngine Datastore,
Microsoft Azure, and others that Gora might include in the future.
All the other modules have to extend from those two specific packages depending on their own
design. That is one of the changes made to Cassandra, Acumulo, HBase, SQL modules. They now
extend a PersistentBase class which comes from Avro, but in the other hand, the DynamoDB module
comes directly from the Persistent class which does not use Avro. In the future, we might
want to abstract more similar functionalities from the different web service datastores to
improve this layer." 
3) Formatting (e.g. indentation) will be also smartened up to the default 2 spaces. I should
have known better here and it is my own fault.
4) We will look into justification behind the proposed removal of the @Override annotations
and get back to you on this one.
5) Same with Exception exception, we can resolve these areas in the forthcoming new patch.

Thanks for your comments. None of this is difficult to sort out so we will get a good turnaround
on this stuff.   


                
      was (Author: lewismc):
    Hi Ferdy,
Thanks for the comments. As usual great. Please see my replies.

1) No log4j.properties being changed to DEBUG is a mistake on our side. This will be reverted
to INFO in the forthcoming patch
2) Persistent is changed to PersistentBase because 
3) Formatting (e.g. indentation) will be also smartened up to the default 2 spaces. I should
have known better here and it is my own fault.
4) We will look into justification behind the proposed removal of the @Override annotations
and get back to you on this one.
5) Same with Exception exception, we can resolve these areas in the forthcoming new patch.

Thanks for your comments. None of this is difficult to sort out so we will get a good turnaround
on this stuff.   


                  
> Datastore for gora-dynamodb 
> ----------------------------
>
>                 Key: GORA-103
>                 URL: https://issues.apache.org/jira/browse/GORA-103
>             Project: Apache Gora
>          Issue Type: New Feature
>          Components: storage-dynamodb
>    Affects Versions: 0.3
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>              Labels: gsoc, gsoc2012
>             Fix For: 0.3
>
>         Attachments: GORA-103-final.patch, GORA-103.patch, GORA-103.v2.patch, GORA-103-v3.patch,
GORA-103-v4.patch
>
>
> As per comments on the Gora dev@ mailing list, and per our application submission [1]
and ideas page [2], this issue should track, from start to finish the development, montoring,
reviwing, testing and eventual implementation of the gora-dynamodb module for Gora.
> [1] https://cwiki.apache.org/confluence/display/GORA/GSoC+2012
> [2] https://cwiki.apache.org/confluence/display/GORA/GSoC+2012+Ideas+Page

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message