gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alparslan Avcı (JIRA) <j...@apache.org>
Subject [jira] [Commented] (GORA-94) Upgrade to Apache Avro 1.7.x
Date Thu, 06 Feb 2014 12:52:09 GMT

    [ https://issues.apache.org/jira/browse/GORA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13893322#comment-13893322
] 

Alparslan Avcı commented on GORA-94:
------------------------------------

{code:java}webPage.getHeaders().clear(); //TODO clear method does not work{code}
Actually, this clear method mentioned above is DirtyMapWrapper.clear() method. 

In gora trunk, DataStoreTestUtil.testUpdateWebPage() method works as follows:
# puts _even_ indexed urls to outlinks map
# flushes the datastore
# clears outlinks map
# puts _odd_ indexed urls to outlinks map
# flushes the datastore
# asserts _the size of outlinks map_ is equal to _odd indexed urls count_.

I think, this is the true algorithm for testing the update. However, in GORA_94 branch's DataStoreTestUtil.testUpdateWebPage()
method; it asserts _the size of outlinks map_ is equal to _the total urls count_ at the last
step. The incremental of *j* variable has been somehow changed. I think, it was changed in
order to pass the tests since HBaseStore does not clear the map after DirtyMapWrapper.clear()
method is called. 

Those TODO's are all about this issue. In my opinion, we have to change the test algorithm
back to the old version and fix the stores according to this. You can also check my latest
[comment|https://issues.apache.org/jira/browse/GORA-246?focusedCommentId=13878614&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13878614]
and [patch|https://issues.apache.org/jira/secure/attachment/12624339/GORA-246v5.patch] in
GORA-246 for more info.

> Upgrade to Apache Avro 1.7.x
> ----------------------------
>
>                 Key: GORA-94
>                 URL: https://issues.apache.org/jira/browse/GORA-94
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: build process, storage
>    Affects Versions: 0.2
>            Reporter: Lewis John McGibbney
>            Assignee: Ed Kohlwey
>             Fix For: 0.4
>
>         Attachments: GORA-94-v2.patch, GORA-94-v3.patch, GORA-94-v4.patch, GORA-94.patch,
GORA-94v10.patch, GORA-94v11.patch, GORA-94v12.patch, GORA-94v6.diff, GORA-94v7.patch, GORA-94v8.patch,
GORA-94v9.patch, GORA_94v5.patch
>
>
> I am not sure what this involves as of yet but I have a small feeling that it's going
to be some reasonably major work...  



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message