gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alparslan Avcı (JIRA) <j...@apache.org>
Subject [jira] [Commented] (GORA-94) Upgrade to Apache Avro 1.7.x
Date Tue, 04 Mar 2014 09:48:39 GMT

    [ https://issues.apache.org/jira/browse/GORA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919195#comment-13919195
] 

Alparslan Avcı commented on GORA-94:
------------------------------------

Hi [~lewismc], sorry for the late answer. 

bq. A simple test at the end, in addition to checking the odd indexed urls in the outlinks
map would be for us to get the webpage from the datastore and check the total number of entries
in the outlink map. This would mean we add the the algorithm by doing the final check from
the persisted object.

IMHO, since the outlink map is cleared in the tests, _the total number of entries in the final
map_ has to be equal to _odd indexed urls count_. This is already checked in the tests, so
we do not need to do a final check, I think. Or, have I misunderstood your comment? :)

{quote} 1. Keep your improvements for adding the following methods 
+ DataStoreTestUtil.testUpdateWebPagePutToArray(webPageStore);
+ DataStoreTestUtil.testUpdateWebPagePutToNotNullableMap(webPageStore);
+ DataStoreTestUtil.testUpdateWebPagePutToNullableMap(webPageStore);
+ DataStoreTestUtil.testUpdateWebPageRemoveMapEntry(webPageStore);
+ DataStoreTestUtil.testUpdateWebPageRemoveField(webPageStore);
2. Revert the test algorithm for testUpdate to the implementation currently in trunk
3. Fix datastores in accordance with this.{quote}

+1 on this way. I will start fixing the _clear()_ method problem as soon as possible.

For extra test cases, [~talat] and I have worked together about possible combinations of Avro
field types (like standart types, nullable unions, 3-type unions, unions with maps etc.) and
have seen that there are more than 30 possible combinations. Thus, there are many test cases
that have to be specified and implemented like your suggestions. I propose we can move with
the present test cases for gora-0.4 and think other cases for next versions. This will also
allow us to go into test driven development and give us time for refactoring the ways of implementing
UNION types in more detail (like saving the index of unions on db).



> Upgrade to Apache Avro 1.7.x
> ----------------------------
>
>                 Key: GORA-94
>                 URL: https://issues.apache.org/jira/browse/GORA-94
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: build process, storage
>    Affects Versions: 0.2
>            Reporter: Lewis John McGibbney
>            Assignee: Ed Kohlwey
>             Fix For: 0.4
>
>         Attachments: GORA-94-v2.patch, GORA-94-v3.patch, GORA-94-v4.patch, GORA-94.patch,
GORA-94v10.patch, GORA-94v11.patch, GORA-94v12.patch, GORA-94v6.diff, GORA-94v7.patch, GORA-94v8.patch,
GORA-94v9.patch, GORA_94v5.patch
>
>
> I am not sure what this involves as of yet but I have a small feeling that it's going
to be some reasonably major work...  



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message