gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Renato Javier Marroquín Mogrovejo (JIRA) <j...@apache.org>
Subject [jira] [Commented] (GORA-246) Upgrade to Avro 1.7.X in gora-hbase
Date Mon, 17 Mar 2014 10:48:44 GMT

    [ https://issues.apache.org/jira/browse/GORA-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937654#comment-13937654
] 

Renato Javier Marroquín Mogrovejo commented on GORA-246:
--------------------------------------------------------

Hi Alparslan,

My comments are for the points you stated.

1. You are right on this one i.e. for maps the qualifiers will always be null, so we should
just go ahead and clean up the column. That 'if' is just doing nothing there. So I will take
that condition out and re-run tests.
2. The changes regarding testUpdateWebPageRemoveMapEntry have probably been made on my previous
patch, but I will revert and test it out again.
3. Totally +1 on this one. I am sorry about this, I got too excited about getting those tests
passing ;) 
I will rebase my patches according to your comments Alparslan, and thank you for checking
them out :)

> Upgrade to Avro 1.7.X in gora-hbase
> -----------------------------------
>
>                 Key: GORA-246
>                 URL: https://issues.apache.org/jira/browse/GORA-246
>             Project: Apache Gora
>          Issue Type: Sub-task
>          Components: gora-core, gora-hbase
>    Affects Versions: 0.4
>            Reporter: Lewis John McGibbney
>             Fix For: 0.4
>
>         Attachments: GORA-246.FailingTest.patch, GORA-246.patch, GORA-246v2.patch, GORA-246v3.patch,
GORA-246v3.patch, GORA-246v4.patch, GORA-246v5.patch, GORA_246.HBaseDriverTest.patch, GORA_246.HBaseDriverTest.v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message