gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lewis John McGibbney (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-296) Improve 'Keyclass and nameclass match' logging in HBaseStore
Date Tue, 18 Mar 2014 22:00:48 GMT

    [ https://issues.apache.org/jira/browse/GORA-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939868#comment-13939868
] 

Lewis John McGibbney commented on GORA-296:
-------------------------------------------

Hey [~renato2099] thanks for patch.

{code:title=HBaseStore.java|borderStyle=solid}
+            LOG.warn("Mismatching schema names. Mappingfile schema name: '" + tableNameFromMapping

+                + "'. PersistentClass schema name: '" + tableName + "'. Assuming they are
the same.");
{code}

We remove requirement to invoke log.warn twice. Thanks for taking this on. It is a really
confusing bit of logging and no-one I have ever met has actually understood it first time
around ;)

> Improve 'Keyclass and nameclass match' logging in HBaseStore
> ------------------------------------------------------------
>
>                 Key: GORA-296
>                 URL: https://issues.apache.org/jira/browse/GORA-296
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: gora-hbase
>    Affects Versions: 0.3
>            Reporter: Lewis John McGibbney
>            Assignee: Renato Javier MarroquĂ­n Mogrovejo
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: GORA-296.patch
>
>
> There is an extremely unhelpful snippet of logging which occurs in HBaseStore.
> INFO store.HBaseStore: Keyclass and nameclass match but mismatching table names  mappingfile
schema is 'webpage' vs actual schema '_webpage' , assuming they are the same.
> This is set a level INFO and merely confuses people. i think it should be clearer.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message