gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lewis John McGibbney (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-326) Removal of _g_dirty field from _ALL_FIELDS array and Field Enum in Persistent classes
Date Tue, 15 Jul 2014 14:18:04 GMT

    [ https://issues.apache.org/jira/browse/GORA-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062104#comment-14062104

Lewis John McGibbney commented on GORA-326:

 * Patch checks out, applies (with some minor effort) builds and tests A OK :) :)
 * Some lines have been commented out e.g. //, I am not bothered about this but it may be
best for us to state the Jira issue there as part of the comment to provide a bit more context
for future users. Seeing that the gora-compiler and gora-core/persistency code has been through
major refeactoring recently. 
 * Do you know of any regressions as part of removing the field from existing data beans?
AFACT it looks *much* cleaner from an aesthetic POV, it also removes the problem of including
the dirty field in formulation of Query.
 * I see more additions to data beans in gora-tutorial, I assume we must have missed these
the last time around!!! Woops. Thanks for addressing them here Renato.
I am pretty much +1 on this patch being brought into the codebase but I think we need more
thorough testing.
[~vschiavoni], I wonder if you are interested in porting some tests over to DataStoreTestBase
and subsequently DataStoretestUtil which would replicate the issue you found with TestGoraStorage.
If we could back this patch up with a Unit test to reduce likelihood of regression then it
would be much better for us all and would also build trust in this patch.

> Removal of _g_dirty field from _ALL_FIELDS array and Field Enum in Persistent classes
> -------------------------------------------------------------------------------------
>                 Key: GORA-326
>                 URL: https://issues.apache.org/jira/browse/GORA-326
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: gora-core
>    Affects Versions: 0.4
>            Reporter: Alparslan Avc─▒
>            Priority: Minor
>              Labels: gora-core
>             Fix For: 0.5
>         Attachments: GORA-326.patch, GORA-326.v1.patch
> In auto-generated persistent classes, we create an array field called ALL_FIELDS as you
know. But this array also contains _g_dirty field, which is not a stored field at all. Maybe
we should remove _g_dirty field from the array, since the array is used for getting all fields
in the stored table. We can also remove it from Field enum, so the users do not know about
the _g_dirty field.

This message was sent by Atlassian JIRA

View raw message