gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Palsulich (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (GORA-354) Clarify lowercasing of DataStoreFactory#findProperty
Date Tue, 15 Jul 2014 13:31:05 GMT

    [ https://issues.apache.org/jira/browse/GORA-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062046#comment-14062046
] 

Tyler Palsulich edited comment on GORA-354 at 7/15/14 1:29 PM:
---------------------------------------------------------------

Hi [~renato2099],

Thanks for the comments!
1) IMHO, we should try to use the user's settings first. It doesn't seem natural to silently
make the property lowercase, even if we notify the user of the mistake after. How much does
the extra if cost?
    Edit: I might be misunderstanding you. Making the class name always lowercase, I'm good
with. Making the (unqualified, no class names before) property name always lower case, even
if the user defines it as mixed case, -1.
2) Thanks! Can always use more tests. :)
3) Would you prefer the line before? Or, just take the comment out.


was (Author: tpalsulich):
Hi [~renato2099],

Thanks for the comments!
1) IMHO, we should try to use the user's settings first. It doesn't seem natural to silently
make the property lowercase, even if we notify the user of the mistake after. How much does
the extra if cost?
2) Thanks! Can always use more tests. :)
3) Would you prefer the line before? Or, just take the comment out.

> Clarify lowercasing of DataStoreFactory#findProperty
> ----------------------------------------------------
>
>                 Key: GORA-354
>                 URL: https://issues.apache.org/jira/browse/GORA-354
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: gora-core
>    Affects Versions: 0.5
>            Reporter: Lewis John McGibbney
>            Assignee: Tyler Palsulich
>            Priority: Critical
>             Fix For: 0.5
>
>         Attachments: GORA-354.palsulich.070914.patch, GORA-354.palsulich.071414.full.patch,
GORA-354.palsulich.071514.full.patch, GORA-354.unit-test.patch
>
>
> Right now it appears that the reading of key's and value's from DataStoreFactory#findProperty
is a process which does not lowercase keys or values.
> This can result in undesired behavhiour meaning that configuration properties are not
used properly @Runtime.
> The fix should be a lowercasing of all properties so that they can be stored within and
read from the call to System properties.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message