gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lewis John McGibbney (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (GORA-377) Implement gora-metamodel module
Date Wed, 15 Oct 2014 16:47:34 GMT

    [ https://issues.apache.org/jira/browse/GORA-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172575#comment-14172575
] 

Lewis John McGibbney edited comment on GORA-377 at 10/15/14 4:46 PM:
---------------------------------------------------------------------

OK, a few comments
 * I think that this is *the best* opportunity for us to hash out some documentation for the
Metamodule integration. I've therefore put a placeholder [here|http://gora.apache.org/current/gora-metamodel.html].
If you could work with us on documentation here I think it would be excellent.
 * I've also opened a ticket for the [implementation of local filters|https://issues.apache.org/jira/browse/GORA-387]
as per your comment within MetaModelQuery.java
 * I think we should log all of your TODO's as Jira issues and mark them with the 'metamodel'
tag. I've created a tag for this.
 * It would be really nice to see some Javadoc for critical methods such as MetaModelQuery#toMetaModelQuery...
this is one of the most important methods in the entire module.
 * Am I right in saying here that gora-metamodel will not be used for executing *anything*
in a Mapreduce-like fashion? I see that you have no included any tracking counter for MetaModelResult#getProgress(),
this is usually used to return progress on the executing of some MR task. This would be backed
up by the absence of any implementation for MetaModelStore#getPartitions(Query<K, T>
query).
 * MetaModelStore#put(K key, T obj) and deleteByQuery(Query<K, T> query) are both absent.

I've quickly corrected formatting for the code contained within patch, corrected some of the
Maven configuration within gora-metamodel/pom.xml, added license headers for missing files
and pushed a fresh PR, which can be found [here|https://github.com/apache/gora/pull/13]


was (Author: lewismc):
OK, a few comments
 * I think that this is *the best* opportunity for us to hash out some documentation for the
Metamodule integration. I've therefore put a placeholder [here|http://gora.apache.org/current/gora-metamodule.html].
If you could work with us on documentation here I think it would be excellent.
 * I've also opened a ticket for the [implementation of local filters|https://issues.apache.org/jira/browse/GORA-387]
as per your comment within MetaModelQuery.java
 * I think we should log all of your TODO's as Jira issues and mark them with the 'metamodel'
tag. I've created a tag for this.
 * It would be really nice to see some Javadoc for critical methods such as MetaModelQuery#toMetaModelQuery...
this is one of the most important methods in the entire module.
 * Am I right in saying here that gora-metamodel will not be used for executing *anything*
in a Mapreduce-like fashion? I see that you have no included any tracking counter for MetaModelResult#getProgress(),
this is usually used to return progress on the executing of some MR task. This would be backed
up by the absence of any implementation for MetaModelStore#getPartitions(Query<K, T>
query).
 * MetaModelStore#put(K key, T obj) and deleteByQuery(Query<K, T> query) are both absent.

I've quickly corrected formatting for the code contained within patch, corrected some of the
Maven configuration within gora-metamodel/pom.xml, added license headers for missing files
and pushed a fresh PR, which can be found [here|https://github.com/apache/gora/pull/13]

> Implement gora-metamodel module
> -------------------------------
>
>                 Key: GORA-377
>                 URL: https://issues.apache.org/jira/browse/GORA-377
>             Project: Apache Gora
>          Issue Type: New Feature
>          Components: gora-metamodel
>            Reporter: Lewis John McGibbney
>             Fix For: 0.6
>
>         Attachments: GORA-377_patch1.diff
>
>
> There have been recent discussions [0] around implementing MetaModel [1] in a drive to
improving the Gora Query model and functionality.
> This issue is merely a placeholder for implementing exctly that.
> [0] http://www.mail-archive.com/dev%40gora.apache.org/msg05149.html
> [1] http://metamodel.incubator.apache.org/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message