gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-390) Gora compiler generate wrong isDirtyXXXX method signature
Date Wed, 22 Oct 2014 23:56:34 GMT

    [ https://issues.apache.org/jira/browse/GORA-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180761#comment-14180761
] 

ASF GitHub Bot commented on GORA-390:
-------------------------------------

Github user hsaputra commented on the pull request:

    https://github.com/apache/gora/pull/16#issuecomment-60174409
  
    LGTM 
    
    +1


> Gora compiler generate wrong isDirtyXXXX method signature
> ---------------------------------------------------------
>
>                 Key: GORA-390
>                 URL: https://issues.apache.org/jira/browse/GORA-390
>             Project: Apache Gora
>          Issue Type: Bug
>          Components: gora-compiler
>    Affects Versions: 0.5
>            Reporter: Damien Raude-Morvan
>            Priority: Minor
>
> Hi,
> I think I've spotted a small issue with actual code generated by gora-compiler.
> For each field in source Avro schema, it will generate a isDirtyXXX method which have
a _value_ parameter which is not really used.
> For instance, for a _content_ field, the following code is generated :
> {code}
>   public boolean isContentDirty(java.lang.CharSequence value) {
>     return isDirty(6);
>   }
> {code}
> I would expect the following code to be generated instead (ie. without value parameter)
:
> {code}
>   public boolean isContentDirty() {
>     return isDirty(6);
>   }
> {code}
> Regards,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message