gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-390) Gora compiler generate wrong isDirtyXXXX method signature
Date Thu, 30 Oct 2014 00:15:34 GMT

    [ https://issues.apache.org/jira/browse/GORA-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14189358#comment-14189358
] 

Hudson commented on GORA-390:
-----------------------------

SUCCESS: Integrated in gora-trunk #1285 (See [https://builds.apache.org/job/gora-trunk/1285/])
GORA-390 Rework generated isXXXDirty methods. (drazzib: rev dc5996a5c110ca04e2a641c865f94ffe889f84fb)
* gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm
GORA-390 Re-generate all Gora objects from their schemas. (drazzib: rev 80d5d8d1c6f0f24772a1039f8220c679ffca6ea6)
* gora-tutorial/src/main/java/org/apache/gora/tutorial/log/generated/Pageview.java
* gora-tutorial/src/main/java/org/apache/gora/tutorial/log/generated/MetricDatum.java
* gora-core/src/examples/java/org/apache/gora/examples/generated/Metadata.java
* gora-goraci/src/main/java/org/apache/gora/goraci/generated/CINode.java
* gora-core/src/examples/java/org/apache/gora/examples/generated/V2.java
* gora-goraci/src/main/java/org/apache/gora/goraci/generated/Flushed.java
* gora-core/src/examples/java/org/apache/gora/examples/generated/TokenDatum.java
* gora-core/src/examples/java/org/apache/gora/examples/generated/Employee.java
* gora-core/src/examples/java/org/apache/gora/examples/generated/WebPage.java
* gora-core/src/examples/java/org/apache/gora/examples/generated/ImmutableFields.java
GORA-390: Add information into CHANGES.txt (drazzib: rev 0126ecd900ec6c9b036db4312073d5ec8ad5f1ca)
* CHANGES.txt


> Gora compiler generate wrong isDirtyXXXX method signature
> ---------------------------------------------------------
>
>                 Key: GORA-390
>                 URL: https://issues.apache.org/jira/browse/GORA-390
>             Project: Apache Gora
>          Issue Type: Bug
>          Components: gora-compiler
>    Affects Versions: 0.5
>            Reporter: Damien Raude-Morvan
>            Priority: Minor
>             Fix For: 0.6
>
>
> Hi,
> I think I've spotted a small issue with actual code generated by gora-compiler.
> For each field in source Avro schema, it will generate a isDirtyXXX method which have
a _value_ parameter which is not really used.
> For instance, for a _content_ field, the following code is generated :
> {code}
>   public boolean isContentDirty(java.lang.CharSequence value) {
>     return isDirty(6);
>   }
> {code}
> I would expect the following code to be generated instead (ie. without value parameter)
:
> {code}
>   public boolean isContentDirty() {
>     return isDirty(6);
>   }
> {code}
> Regards,



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message